Skip to content

Move board rpc commands in their own package #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

matteosuppo
Copy link
Contributor

Keeping with the process of isolating features, the board commands
have been moved in their own package.

Nothing should change from the user perspective

Signed-off-by: Matteo Suppo [email protected]

Keeping with the process of isolating features, the board commands
have been moved in their own package.

Nothing should change from the user perspective

Signed-off-by: Matteo Suppo <[email protected]>
@matteosuppo matteosuppo marked this pull request as ready for review February 14, 2020 10:17
@matteosuppo matteosuppo requested a review from masci February 14, 2020 10:17
@rsora rsora added this to the 0.10.0 milestone Mar 4, 2020
@cmaglie
Copy link
Member

cmaglie commented Mar 5, 2020

A related comment from @kittaakos:

Hi @andmeyee you're right, at this moment settings are global,

@masci, before the introduction of the new Settings API, two services were available: the ArduinoCore and the Monitor. I thought the clear separation of these two services was based on the fact that the Monitor service is entirely independent of the ArduinoCore since one could tune the datadir, sketchbookdir, downloadsdir, and the boardmanageradditionalurlsList in the InitRequest's Configuration. So it made sense to have one single gRPC monitor client and several Arduino core clients, as they were initialized differently.

My questions would be the followings:

Knowing that the settings are global, would you still recommend downstream consumers of the CLI to maintain multiple ArduinoCore gRPC clients, or is it safe to have one and share it?
If it is safe to share one ArduinoCore gRPC client, what is the benefit of having three different types of clients (Settings, ArduinoCore, and Monitor)? As a consumer of the CLI, I have to maintain the lifecycle of three different gRPC clients, although they're connected to the same server.
Any kind of feedback is welcome on this topic; I am trying to figure out whether we can simplify the architecture of the Pro IDE. Thank you!

@rsora rsora modified the milestones: 0.10.0, 0.11.0 Apr 14, 2020
@umbynos umbynos modified the milestones: 0.11.0, 0.12.0 Jun 17, 2020
@cmaglie cmaglie modified the milestones: 0.12.0, 0.14.0 Sep 14, 2020
@per1234 per1234 added the type: enhancement Proposed improvement label Feb 3, 2021
@github-actions github-actions bot closed this Mar 30, 2021
@per1234 per1234 reopened this Mar 30, 2021
@matteosuppo matteosuppo closed this May 6, 2021
@per1234 per1234 deleted the msuppo/boards branch May 4, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants